Adding Recent Images Tab and making it function.
Removing the Intensity and Frequency from the Histogram
Putting Intensity and Frequency in Tooltips
Making the histogram and sliders work for decimal (double or float) images.
Making the statistics load after the image is fully loaded.
Fixing the Star Profile Viewer issue a different way and fixing a bug
And getting rid of a few warnings
Details
Details
- Reviewers
mutlaqja
Diff Detail
Diff Detail
- Repository
- R321 KStars
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5647 Build 5665: arc lint + arc unit
Comment Actions
Making Histogram panel work better for decimals.
Removing Intensity and Frequency report and putting them in tooltips.
Improving the layout of the Histogram panel.
Comment Actions
Adding a Hide Saturation Spike feature to the histogram
Also preventing moving the max/min cut sliders further out since
this does not make sense unless we can undo the cut.
Comment Actions
Fixing a another bug in StarProfileWidget display and a better solution for the previous issue
| kstars/fitsviewer/fitshistogram.cpp | ||
|---|---|---|
| 62–72 | Please use the new Style for connecting Signal/Slots. | |
| kstars/fitsviewer/fitshistogram.cpp | ||
|---|---|---|
| 62–72 | I can't change the others because they don't seem to work in the new style | |
| kstars/fitsviewer/fitshistogram.cpp | ||
|---|---|---|
| 62–72 | I guess QOverload<int>::of() or QOverload<double>::of() for the second argument is needed for the new connection to work. | |
Comment Actions
According to QT, it looks like trying to make the others work in the new style would require a syntax like this:
...because QSpinBox has two signals named valueChanged() with different arguments. Instead, the new code needs to be:
connect( mySpinBox, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged), mySlider, &QSlider::setValue );
They say "The best thing is probably to recommend not to overload signals or slots …"
But you see, I didn't write the overloaded signals for these classes, QT did.
Do we really want that sort of syntax in the code?
Comment Actions
Too many graphs were on the histogram due to blue and green getting created without being deleted