Remove virtual for non-virtual calls
ClosedPublic

Authored by tcanabrava on Nov 28 2018, 6:34 PM.

Details

Summary

TerminalDisplay is internal to Konsole, and it's never inherited,
that means that the 'virtual' on those functions are dummy and
does nothing besides increase the VTable size.

Diff Detail

Repository
R319 Konsole
Branch
removeNonVirtualCalls
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5478
Build 5496: arc lint + arc unit
tcanabrava created this revision.Nov 28 2018, 6:34 PM
Restricted Application added a project: Konsole. · View Herald TranscriptNov 28 2018, 6:34 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Nov 28 2018, 6:34 PM
hindenburg accepted this revision.Nov 30 2018, 1:40 PM
This revision is now accepted and ready to land.Nov 30 2018, 1:40 PM
This revision was automatically updated to reflect the committed changes.