Differential D17221

Don't hide setFont, it's not virtual
ClosedPublic
Actions

Authored by tcanabrava on Nov 28 2018, 6:32 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:4e83457c06a1: Don't hide setFont, it's not virtual
Summary

setFont is not a virtual method, so overriding it makes no sense.
if you have a pointer to the widget and call setFont things will
still (not) work, and if you have a pointer to the TerminalDisplay
and call setFont, nothing will happen, so just remove it.

Diff Detail

Repository
R319 Konsole
Branch
TerminalDisplayRemoveNonVirtualOverride
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5477
Build 5495: arc lint + arc unit
tcanabrava created this revision.Nov 28 2018, 6:32 PM
Restricted Application added a project: Konsole. · View Herald TranscriptNov 28 2018, 6:32 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Nov 28 2018, 6:32 PM
hindenburg accepted this revision.Nov 30 2018, 1:43 PM
This revision is now accepted and ready to land.Nov 30 2018, 1:43 PM
Closed by commit R319:4e83457c06a1: Don't hide setFont, it's not virtual (authored by tcanabrava, committed by hindenburg). · Explain WhyNov 30 2018, 1:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.h (6 lines)
Msrc/TerminalDisplay.cpp (5 lines)

Diff 46422

View Options

src/TerminalDisplay.h

Loading...
View Options

src/TerminalDisplay.cpp

Loading...