Instead, we want to disallow removing when the count drops to 1.
BUG:401473
Instead, we want to disallow removing when the count drops to 1.
BUG:401473
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
kcms/translations/translationsmodel.cpp | ||
---|---|---|
216 | Changing from index < 1 to checking count makes sense, but I would still check if (index < 0) {return;} in addition to the count to catch out-of-sync erorrs. I think then you wouldn't need to complicate the QML side. |
kcms/translations/translationsmodel.cpp | ||
---|---|---|
216 | I'll add the check (it's nice for sanity anyways), but the changes to the QML are actually unrelated - it's simply the delegate crashing in the Qt Quick runtime when the expression bound to enabled is re-evaluated while the delegate is being destroyed. I didn't find any better fix. |