Sandboxed applications usually don't have access to read kdeglobals configuration. For this
reason we introduced Settings portal, to be able to obtain most necessary configuration without
allowing applications access to hosts configuration. The Settings portal implementation in
xdg-desktop-portals-kde was develop mostly for plasma-integration needs so it allows to get
colors, fonts, widget theme and some other configuration from kdeglobals.
Details
- Reviewers
broulik - Group Reviewers
Plasma - Commits
- R135:64002af69a86: Add support for settings portal
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Good stuff!
src/platformtheme/kfontsettingsdata.cpp | ||
---|---|---|
81 | const | |
131 | Compare with QLatin1String | |
src/platformtheme/kfontsettingsdata.h | ||
70 | const | |
src/platformtheme/khintssettings.cpp | ||
66 | I thought Qt could de-serialize built-in types on its own? | |
79 | Can you put that into some shared header file maybe? | |
357 | Those aren't used as dbus interface names anywhere, right? (asking because of the space) | |
442 | Would be lovely to add a KConfig overload to KColorScheme::createApplicationPalette |
src/platformtheme/khintssettings.cpp | ||
---|---|---|
66 | Nope, I think it can't. You already told me this before, but from my experience I always had to do it this way. | |
79 | They don't seem to share any header file, should I put it into khintsettings.h for example and just include it in kfontsettings.h? | |
357 | No, that's just a name of group or namespace. In kdeglobals "Toolbar style" is name of group, but I had to add some prefix to somehow identify it comes from kdeglobals, because the settings portal can be used also by Gtk apps or any other apps so it has to be clear. Gtk implementation of the settings portal use for example prefix made from GSettings scheme name. | |
442 | Ok, I'll look into that. |
src/platformtheme/khintssettings.cpp | ||
---|---|---|
442 | It looks it's not that simple, this change would require other additions in order to support KConfig overload. I would leave it as it is for now. |