Port applet/containment configs to qqc2
ClosedPublic

Authored by mart on Nov 28 2018, 10:36 AM.

Details

Summary

port the applet config dialogs and containments to
QtQuickControls2 and Kirigami modernizing it,
using form layouts, Headings and inline messages.
look is almost the same modulo fixing some misalignments and following
the hig more closely

BUG: 401472
FIXED-IN: 5.15.0

Test Plan

looked at every wallpaper plugin and
loaded the config dialog of many applets

Diff Detail

Repository
R119 Plasma Desktop
Branch
phab/qqc2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5504
Build 5522: arc lint + arc unit
mart created this revision.Nov 28 2018, 10:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 28 2018, 10:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Nov 28 2018, 10:36 AM
mart added a comment.Nov 28 2018, 10:37 AM

before:


after:

apol added a subscriber: apol.Nov 28 2018, 11:32 AM

+1 cool!

Quirks I have found:

  • The "Filters" page in Folder View configuration doesn't get a size initially and only does when I resize the window
  • The transition animation is buggy, the "enterItem" isn't properly animated from what I can tell, just pops up right away with the old KCM moving away
  • The "Positioning" combobox for the wallpaper disappears when FormLayout is narrow and starts laying out items below eath other

Otherwise pretty good

mart updated this revision to Diff 46397.Nov 28 2018, 11:54 AM

move text in tooltip

mart added a comment.Nov 28 2018, 12:07 PM

oddly seems not all the pages to not animate... i fear they are trying to set anchors?

mart updated this revision to Diff 46398.Nov 28 2018, 12:15 PM
  • initialize a proper size
ngraham requested changes to this revision.Nov 28 2018, 3:17 PM
ngraham added a subscriber: ngraham.

The Layout and Wallpaper Type comboboxes should open on press, not on click-and-release.

The Positioning combobox shouldn't be so much much wider than the other comboboxes; the text of the longest item doesn't seem long enough to cause such a long width.

Is changing the wallpaper plugins button even necessary for this patch? If you think it is, instead of making the wallpaper plugin button icons-only, can we move it to the bottom row with the other GHNS button?

Either way, this patch now fixes https://bugs.kde.org/show_bug.cgi?id=401472 so please add:

BUG: 401472
FIXED-IN: 5.15.0
This revision now requires changes to proceed.Nov 28 2018, 3:17 PM
mart added a comment.EditedNov 29 2018, 10:46 AM

The Layout and Wallpaper Type comboboxes should open on press, not on click-and-release.

ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, tough for combox and menus in particular, is not possible at all the pattern press, open the subpopup, move the mouse to select, release and trigger the menu item. It's a long time that i think how to solve that, but it's a very complicated problem :/
tough the open on press is done now

The Positioning combobox shouldn't be so much much wider than the other comboboxes; the text of the longest item doesn't seem long enough to cause such a long width.

The positioning combobox doesn't come from this form, but from the wallpaper plugin which is elsewhere.
Is a bit difficult as there are 2 different formlayouts as the bottom part is loaded by the wallpaper plugin itself, so needs some kind of sync api between them

Is changing the wallpaper plugins button even necessary for this patch? If you think it is, instead of making the wallpaper plugin button icons-only, can we move it to the bottom row with the other GHNS button?

the button was already there and was quite messy with long texts (very long in english, doesn't fit to the whole window width in german) in that case for now i find it cleared near the combobox

Either way, this patch now fixes https://bugs.kde.org/show_bug.cgi?id=401472 so please add:

BUG: 401472
FIXED-IN: 5.15.0
mart edited the summary of this revision. (Show Details)Nov 29 2018, 10:49 AM
mart added a comment.Nov 29 2018, 12:50 PM
In D17211#367974, @mart wrote:

ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, tough for combox and menus in particular, is not possible at all the pattern press, open the subpopup, move the mouse to select, release and trigger the menu item. It's a long time that i think how to solve that, but it's a very complicated problem :/
tough the open on press is done now

scratch that, i found an hack that makes it work, it's in master now :p

mart added a comment.Nov 29 2018, 1:19 PM

the shrinking of the wallpaper combobox will be done in a separate commit

abetts added a subscriber: abetts.Nov 29 2018, 3:11 PM

+1 on visuals

Thanks, the combobox open-on-click feature works perfectly!

I still don't agree with making the wallpaper plugin GHNS button icons-only. That makes it inconsistent with all others in every other KCM and I took great pain recently to make them all consistent. Can we put it on the bottom row with the other one and restore its text?

Thanks, the combobox open-on-click feature works perfectly!

I still don't agree with making the wallpaper plugin GHNS button icons-only. That makes it inconsistent with all others in every other KCM and I took great pain recently to make them all consistent. Can we put it on the bottom row with the other one and restore its text?

From the latest image, it seems that there are 2 buttons that do GHNS.

mart updated this revision to Diff 46481.Nov 29 2018, 3:33 PM
  • show the label again, but shorter
ngraham accepted this revision.Nov 29 2018, 3:57 PM

+1 shipit!

This revision is now accepted and ready to land.Nov 29 2018, 3:57 PM
This revision was automatically updated to reflect the committed changes.