Subs and functions could be unnamed in closures.
Details
Details
Diff Detail
Diff Detail
- Repository
- R216 Syntax Highlighting
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for the review. Btw, is there any chance to preserve my name/email in the final commit?
Comment Actions
Sure :/ I missed to change author last time, I normally am just patching/landing via arc, but that doesn't always contain that.
Comment Actions
It seems this commit is the reason for the unittest failure below?
--- "/home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 SUSEQt5.10/autotests/folding/brightscript.brs.fold" 2018-11-28 07:43:45.708060965 +0000 +++ "/home/jenkins/workspace/Frameworks/syntax-highlighting/kf5-qt5 SUSEQt5.10/build/autotests/folding.out/brightscript.brs.fold" 2018-11-28 07:45:08.202953752 +0000 @@ -96,4 +96,10 @@ b.foo("string",1,{a:b},1.5,[1,2,3]) a = b.foo("string",1,{a:b},1.5,[1,2,3]) + +unnamed_function = function ( a as Integer ) as Float +end function + +unnamed_sub = sub ( a as Integer ) as Void +end sub endFunction FAIL! : FoldingTest::testFolding(brightscript.brs) Compared values are not the same Actual (proc.exitCode()): 1 Expected (0) : 0
Comment Actions
This language does not have folding test. I did not provide validation for it before. Should I do that?