Differential D17189

[useractions] Use checkable actions in the multiple desktops popup
AbandonedPublic
Actions

Authored by zzag on Nov 27 2018, 3:47 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

This improves visuals of the popup a little bit.

Test Plan

Before:

After:

Diff Detail

Repository
R108 KWin
Branch
useractions-multiple-desktops-popup-padding
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5421
Build 5439: arc lint + arc unit
zzag created this revision.Nov 27 2018, 3:47 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 27 2018, 3:47 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Nov 27 2018, 3:47 PM
broulik added a subscriber: broulik.Nov 27 2018, 3:59 PM

Wasn't that done on purpose so the menu stays open when you interact with any of the checkboxes? The same applies also to the "Move to Activities" menu. Given we don't have that anywhere else, might be sensible to just use a regular menu entry instead.

broulik added a comment.Nov 27 2018, 4:31 PM

Also see Bug 401437

zzag planned changes to this revision.Nov 27 2018, 4:40 PM
In D17189#366825, @broulik wrote:

Wasn't that done on purpose so the menu stays open when you interact with any of the checkboxes?

Probably. The problem is checkboxes and checkable menu items can by styled differently, it would be great if UI is consistent.

zzag abandoned this revision.EditedNov 27 2018, 6:12 PM

Nah, without using dirty hacks that's not possible to keep qmenu alive.

Also, this part of UI is not accessed too often so maybe that's fine to have some inconsistency. Still, I'd prefer to use checkable actions instead of checkboxes.

Revision Contents
Changeset List

PathPackages
Museractions.cpp (14 lines)

Diff 46320

View Options

useractions.cpp

Loading...