Potentially fix an issue with some Qt versions
Needs ReviewPublic

Authored by apol on Nov 26 2018, 7:44 PM.

Details

Reviewers
sredman
Group Reviewers
KDE Connect
Summary

It would refuse to launch the sms application otherwise saying that the model
has the wrong type, wrongly.

Diff Detail

Repository
R224 KDE Connect
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5401
Build 5419: arc lint + arc unit
apol created this revision.Nov 26 2018, 7:44 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 26 2018, 7:44 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
apol requested review of this revision.Nov 26 2018, 7:44 PM

Is there a QTBUG or can you add a comment? This sounds like a weird change to be neccessary. I recall there was a bug in Qt 5.12 where some properties like "column" were added as context properties leading to unexpected behavior; could this be related?

Unfortunately, this doesn't work for me

On Ubuntu Gnome 18.04.1:
One note is I had to change the Kirigami version in ConversationDisplay.qml to 2.3 since Ubuntu apparently doesn't package 2.4

kdeconnect.sms.conversations_list: Constructing ConversationListModel(0x55766b4f7b40)
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
QQmlComponent: Component is not ready
Segmentation fault (core dumped)

On Fedora 27 (Plasma) I get:
file:///usr/lib64/qt5/qml/org/kde/kirigami.2/Page.qml:276:5: QML Loader: Binding loop detected for property "active"
Segmentation fault (core dumped)

(The same if I change Kirigami to 2.3 even though 2.4 is installed)

apol added a comment.Dec 3 2018, 12:38 PM

So if you change the import it works okay?

In D17179#370680, @apol wrote:

So if you change the import it works okay?

No. It doesn't work at all. If I change the import, it stops complaining abou that and crashes instead