Integrates better with Kirigami.
- Group Reviewers
- R134:50c69c2c069f: Drop tab-based UI for the about page
Integrating it in one page is definitely an improvement!
Some detailed comments (I am aware that those things introduced with this layout change, they just become apparent now):
- "About" at the top of the page and "About Discover..." are redundant. I'd recommend just integrating the Copyright and license lines above the hline and removing the "About Discover..." heading
- "Libraries" -> "Libraries used" (might be a bit too long for a tab title but as a title on a page it's perfectly fine)
- I'd maybe remove the "Please use..." line above the authors because we have the "Report Bug..." button at the top anyway so it would be redundant. If you fear that users might miss the button up there, I'd opt for moving the button elsewhere rather than having two different places for bug reporting on the same page
It does seem that the bugAddress being an email address is a bit odd... The address given by KAboutData::bugAddress can be either an email address, or a URL, though, so it might make sense to try and handle either case (something as simple as checking for :// in the string would probably work), to make the functionality here functionally equivalent to the qwidget dialogue.
At the same time, though, given that Discover's /is/ an email address... would it perhaps make sense to at least add bugs.kde.org as a link? (or, some other way of adding a secondary link for reports... though that does seem to be veering somewhat outside the scope of this particular patch)
It was on the last version. I could easily see people going to send developers an e-mail instead of reporting the issue properly, that's why I put it there.
Did you like it better up there?
Yeah, I did prefer it in the toolbar. I think that actually makes it more prominent, not less. If we are worried about people sending the developers too many emails, we could de-emphasize the email address. The current UI just uses a tiny button which seems adequately obfuscatory :) Or maybe the developer's name could be a mailto link instead of having the address itself visible in plain view?