Set error if a kjob host disappears from kuiserver with active jobs
ClosedPublic

Authored by davidedmundson on Nov 26 2018, 12:42 PM.

Details

Summary

If the host of a kjob crashes or is killed kuiserver currently reports
that the job has been completed successfully. This is seriously wrong as
it could lead a user to perform a potentially destructive operation.

Setting any error (that's not 0 or 1) will cause plasmashell, the main
kuiserver view, to show a persistent notification that a job has failed.

For master I will use a more correct new enum, new error text, and a way
to tell for KIO operations to report to the uiserver if the host
crashing is important or not.

CCBUG: 352761

Test Plan

Whilst copying a million files killed dolphin
Got a persistent error instead of a success message on the last file it was on

Moving files successfully then killing the app remained fine

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 26 2018, 12:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 26 2018, 12:42 PM
broulik accepted this revision.Nov 26 2018, 1:02 PM
broulik added a subscriber: broulik.

5.12 please

This revision is now accepted and ready to land.Nov 26 2018, 1:02 PM
This revision was automatically updated to reflect the committed changes.