Differential D17169

Include Breeze scrollbar CSS inline
ClosedPublic
Actions

Authored by broulik on Nov 26 2018, 8:48 AM.

Tags

Subscribers

Details

Reviewers

davidedmundson
fvogt

Group Reviewers

Commits

R856:1b06fe651c74: Include Breeze scrollbar CSS inline

Summary

You cannot access cssRules for <link rel="stylesheet" ..> on a different domain since Chrome 64.
Since our chrome-extension:// URL for a stylesheet would be on a different domain than the website,
this can lead to problems in e.g. modernizr, so include the <style> inline instead.

Test Plan

No longer get Failed to read the 'cssRules' property from 'CSSStyleSheet': Cannot access rules on some websites
Scroll bars still look pretty

Diff Detail

Repository

R856 Plasma Browser Integration

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Nov 26 2018, 8:48 AM

Restricted Application added a project: Plasma. · View Herald TranscriptNov 26 2018, 8:48 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Nov 26 2018, 8:48 AM

davidedmundson accepted this revision.Nov 26 2018, 11:24 AM

This revision is now accepted and ready to land.Nov 26 2018, 11:24 AM

Closed by commit R856:1b06fe651c74: Include Breeze scrollbar CSS inline (authored by broulik). · Explain WhyNov 26 2018, 12:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
D	M		extension/breeze-scroll-bars.css (37 lines)
M			extension/content-script.js (58 lines)
M			extension/manifest.json (3 lines)

Diff 46240

extension/breeze-scroll-bars.css

Loading...

extension/content-script.js

Loading...

extension/manifest.json

Loading...