Differential D17164

Fix container detach warnings from clazy
ClosedPublic
Actions

Authored by nicolasfella on Nov 25 2018, 10:58 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:bd17dc2041f1: Fix container detach warnings from clazy

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Nov 25 2018, 10:58 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 25 2018, 10:58 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Nov 25 2018, 10:58 PM
apol accepted this revision.Nov 26 2018, 12:11 PM
apol added a subscriber: apol.
apol added inline comments.
cli/kdeconnect-cli.cpp
156

Why didn't you use qAsConst here?

This revision is now accepted and ready to land.Nov 26 2018, 12:11 PM
nicolasfella added inline comments.Nov 26 2018, 12:20 PM
cli/kdeconnect-cli.cpp
156

According to http://doc.qt.io/qt-5/qtglobal.html#qAsConst qAsConst only works for lvalues, not rvalues, so it can't be used directly on the result of a method call.

Closed by commit R224:bd17dc2041f1: Fix container detach warnings from clazy (authored by nicolasfella). · Explain WhyNov 26 2018, 12:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46252

View Options

cli/kdeconnect-cli.cpp

Loading...
View Options

core/daemon.cpp

Loading...
View Options

core/device.cpp

Loading...
View Options

interfaces/remotesinksmodel.cpp

Loading...
View Options

plugins/sendnotifications/sendnotifications_config.cpp

Loading...
View Options

plugins/systemvolume/systemvolumeplugin-pulse.cpp

Loading...
View Options

tests/testsocketlinereader.cpp

Loading...
View Options

tests/testsslsocketlinereader.cpp

Loading...