Harmonize handling of underscore in query parser
ClosedPublic

Authored by bruns on Nov 25 2018, 9:38 PM.

Details

Summary

The engine differentiates between independent terms, and adjacent terms
forming a phrase. The latter is e.g. used for mail addresses and file
names, "ice@fire.com" or "foo_bar.png". In the database these are stored
without any punctuation characters, but with their relative positions.

While most punctuation characters (e.g. ".", ",", "/", "-", ...) are
treated the same, underscore was handled differently. A query for
"foo-bar.png" searches for the three adjacent terms, while "foo_bar png"
searches for the three terms in any order.

Treat "_" like any other punctuation character. For this to work, the
delimiter has to be checked from the original input string, not the
text mangled for QTextBoundaryFinder.

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Nov 25 2018, 9:38 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 25 2018, 9:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Nov 25 2018, 9:38 PM
poboiko accepted this revision.Mar 17 2019, 4:34 PM
This revision is now accepted and ready to land.Mar 17 2019, 4:34 PM
This revision was automatically updated to reflect the committed changes.