Differential D17142

Further Improve asktoSave
ClosedPublic
Actions

Authored by rizzitello on Nov 24 2018, 8:24 PM.

Details

Reviewers
tcanabrava
patrickelectric
laysrodrigues
Commits
R231:23d6d03ff5ed: Further Improve asktoSave
R231:192c3faa4f7f: Shorten code Fix i18n args Fix Crash on saveall Signed-off-by: Chris Rizzitello…
R231:45c0bcc69dbb: Clang-Tidy, Clazy
Summary
  • Clang and Tidy Split from D17106
  • Shorten remove * code
  • Fix i18n args
  • Fix Crash on save all Signed-off-by: Chris Rizzitello <rizzitello@kde.org>

Diff Detail

Repository
R231 Atelier
Branch
askToSaveBetter
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5341
Build 5359: arc lint + arc unit
rizzitello requested review of this revision.Nov 24 2018, 8:24 PM
rizzitello created this revision.
rizzitello updated this revision to Diff 46159.Nov 24 2018, 8:27 PM
  • Shorten code
patrickelectric accepted this revision.Nov 24 2018, 8:36 PM
This revision is now accepted and ready to land.Nov 24 2018, 8:36 PM
laysrodrigues accepted this revision.Nov 25 2018, 12:15 AM
rizzitello closed this revision.Nov 25 2018, 12:16 AM

Revision Contents
Changeset List

PathPackages
Msrc/mainwindow.cpp (36 lines)

Diff 46167

View Options

src/mainwindow.cpp

Loading...