In the case where a user already logged in and has a session key created, their tracks are never scrobbled because m_networkAccessManager will never be initialized. The initialization is done inside getAuthToken which is not called if a session key is available.
Details
Details
With internet connection:
- Have JuK already configured for scrobbling with Settings -> Configure Scrobbling
- Play a track and observe the track being scrobbled on the last.fm website
With no internet connection:
- Have JuK already configured for scrobbling with Settings -> Configure Scrobbling
- Play a track and JuK does not crash
Starting with internet connection then disabling connection:
- Have internet connection enabled
- Have JuK already configured for scrobbling with Settings -> Configure Scrobbling
- Play a track and observe the track being scrobbled on the last.fm website
- Disconnect internet connection
- Play a track and JuK does not crash
Diff Detail
Diff Detail
- Repository
- R344 Juk
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for the patch! Since the m_networkAccessManager is now sure to be constructed once the Scrobbler constructor runs, I decided instead to just initialize that variable directly without making it conditional, and remove its creation in getAuthToken.
I've committed it to 18.12 and master.
Comment Actions
Sounds good! Thanks!
However do bear in mind that in the original code, m_networkAccessManager would not be initialized if no username and password were provided. You can see that in the Scrobbler::getAuthToken() method. I'm not sure if constructing or retaining QNetworkAccessManager is actually expensive enough for us to care, but I was following the convention I found in the code.