Differential D17130

Fix projectmodel unittest to work on Windows.
ClosedPublic
Actions

Authored by volden on Nov 24 2018, 5:47 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:de81ab5c5b48: Fix projectmodel unittest to work on Windows.
Summary

Fix projectmodel unittest to work on Windows. Use paths according to the platform we are using

Test Plan

Compile and test on Windows (Debug build) to see the unittests are passing. Compile and test on Linux to see that the test pass (As before)

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
volden created this revision.Nov 24 2018, 5:47 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptNov 24 2018, 5:47 AM
volden requested review of this revision.Nov 24 2018, 5:47 AM
volden updated this revision to Diff 46106.Nov 24 2018, 8:18 AM

Renaming to prependPathRoot

volden updated this revision to Diff 46211.Nov 25 2018, 4:35 PM

Prefer QDir::rootPath() to poluting our files with define macros

kfunk accepted this revision.Nov 26 2018, 9:18 AM
This revision is now accepted and ready to land.Nov 26 2018, 9:18 AM
volden added a comment.Nov 26 2018, 11:38 AM

@kfunk Land on 5.3 and merge to master? (For this and the other ones?)

kfunk added a comment.Nov 26 2018, 11:44 AM

Yes, please.

Closed by commit R32:de81ab5c5b48: Fix projectmodel unittest to work on Windows. (authored by volden). · Explain WhyNov 26 2018, 12:11 PM
This revision was automatically updated to reflect the committed changes.
kfunk added inline comments.Nov 26 2018, 12:18 PM
kdevplatform/util/path.cpp
163

Ah, one thing: Could you use qCWarning(UTIL) here?

volden added inline comments.Nov 26 2018, 12:37 PM
kdevplatform/util/path.cpp
163

Sure. Will fix that now.

Revision Contents
Changeset List

Diff 46250

View Options

kdevplatform/project/tests/test_projectmodel.cpp

Loading...
View Options

kdevplatform/util/path.cpp

Loading...