You need to write BUG: 397913 in the summary section, and then remove all mention of it from the title. Please read https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

Almost there. :) Now rewrite the Title in the form of a statement that describes the problem that this patch is fixing. Something like "Don't reverse order of files opened from the command line"

In D17124#365006, @ngraham wrote:

Almost there. :) Now rewrite the Title in the form of a statement that describes the problem that this patch is fixing. Something like "Don't reverse order of files opened from the command line"

Thank you very much for your support :-)

(That's the linked bug report)

In D17124#365557, @gmolteni wrote:

In D17124#365212, @ngraham wrote:

Thanks! I can verify that this fixes the case where you do kate file1 file2 file3 when kate is not already open; now they are opened in the correct order! But when Kate is already open with a few files in tabs, the new files are opened in tabs but in the wrong order. Do you think you could fix that too?

I think that perhaps fixing it is an advanced topic.
The original fix I did was to reverse the order of a foreach loop.
I already located the other foreach loop that is necesary to reverse in order to improve that second case,
but the final result needs a third fix (i will try to but i guess it requires scratching the code much deeper).

With the current fix (foreach at line 178@kateapp.cpp) :

kate f1 f2 f3 --- 1st invocation produces ---> f1 f2 f3
kate f4 f5 f6 --- 2nd invocation produces ---> f6 f5 f4 f1 f2 f3

Fixing a second foreach loop (foreach at line 423@main.cpp) will gave us this:

kate f4 f5 f6 --- 2nd invocation produces ---> f4 f5 f6 f1 f2 f3

However, the main issue here is that i have no idea how to let kate to insert the files
to the right of list instead of the left of the list.

I will invest some time trying to understand kate deeper, but I have no idea where how to find
that part of code.

Thanks for looking into it! Inserting to the left is probably fine, as long as the ordering of the files specified on the command line is preserved.

In D17124#365561, @ngraham wrote:

Thanks for looking into it! Inserting to the left is probably fine, as long as the ordering of the files specified on the command line is preserved.

excelent !! i will do the new commit today !

In D17124#365561, @ngraham wrote:

Thanks for looking into it! Inserting to the left is probably fine, as long as the ordering of the files specified on the command line is preserved.

when I did arc diff again, it reported new diff link is this: https://phabricator.kde.org/D17144

Oops, that means that either you weren't on the bug-397913 branch, or you added the --create argument.

You can Abandon this revision and we can continue from D17144.

In D17124#365580, @ngraham wrote:

Oops, that means that either you weren't on the bug-397913 branch, or you added the --create argument.

You can Abandon this revision and we can continue from D17144.

I made a mistake it seems i commited it as master... let me try again commiting from correct branch