Improve the UI for MainWindow::askToSave
ClosedPublic

Authored by rizzitello on Fri, Nov 23, 4:21 AM.

Details

Summary
Change "Ignore" to "Discard Changes" to be consistent with kate
Disable Save Selected until item is selected
Test Plan


Diff Detail

Repository
R231 Atelier
Branch
ImproveSaveDialogUI
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5326
Build 5344: arc lint + arc unit
rizzitello requested review of this revision.Fri, Nov 23, 4:21 AM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Fri, Nov 23, 4:23 AM
rizzitello edited the test plan for this revision. (Show Details)
rizzitello added a project: Atelier.
rizzitello added a subscriber: Atelier.
tcanabrava requested changes to this revision.Fri, Nov 23, 10:33 AM
tcanabrava added inline comments.
src/mainwindow.cpp
432–436

sabeBtn->setEnabled(currentRow >= 0); ?

This revision now requires changes to proceed.Fri, Nov 23, 10:33 AM
rizzitello updated this revision to Diff 46077.Fri, Nov 23, 2:47 PM
rizzitello marked an inline comment as done.
  • Tomaz Suggestion
rizzitello set the repository for this revision to R231 Atelier.Fri, Nov 23, 2:55 PM
tcanabrava accepted this revision.Fri, Nov 23, 2:57 PM
This revision is now accepted and ready to land.Fri, Nov 23, 2:57 PM
patrickelectric accepted this revision.Sat, Nov 24, 5:56 PM
rizzitello updated this revision to Diff 46149.Sat, Nov 24, 6:28 PM
  • Remove new icon for delete use standard icon instead for fallback
rizzitello edited the summary of this revision. (Show Details)Sat, Nov 24, 6:29 PM
rizzitello closed this revision.Sat, Nov 24, 6:30 PM