Differential D1711

[server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed
ClosedPublic
Actions

Authored by graesslin on May 30 2016, 9:23 AM.

Details

Reviewers
sebas
Group Reviewers
Plasma
Commits
R127:4971be582ce7: [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed
Summary

Unlike the other cases this one is not as dangerous as the shadow
protocol doesn't have a destructor request (yet).

Once that is added the problem would be the same: destroying the
ShadowInterface when the parent SurfaceInterface gets destroyed would
result in a protocol error on client side.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4059.May 30 2016, 9:23 AM
graesslin retitled this revision from to [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 30 2016, 9:23 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.May 31 2016, 8:51 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.May 31 2016, 8:51 PM
Closed by commit R127:4971be582ce7: [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed (authored by graesslin). · Explain WhyJun 1 2016, 5:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4114

View Options

autotests/client/test_shadow.cpp

Loading...
View Options

src/server/shadow_interface.cpp

Loading...