In JavaImport::fillSource(), replace method vararg notation "..." occurring in the input word by "[]".
CCBUG: 401290
Details
Details
Diff Detail
Diff Detail
- Repository
- R139 Umbrello
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The title of this commit is inappropriate, because the patch does not fix the initially reported regression, but converts the java specific notation '...' into a language independent array definition.
BUG:292239
This patch does not close the actual reported problem, therefore
CCBUG:292239
Alternatively, an independent bug report could be submitted for this subproblem so that it appears as a separate entry in the list of fixed bugs for the next release 2.27 https://umbrello.kde.org/developers.php#changelog
In this case, FIXED-IN: should be added to the keywords:
BUG:XXX
FIXED-IN:2.26.90 (KDE Applications 18.11.90)
BTW: bug fixes without any translation related changes could be applied to the stable branch, which is currently Applications/18.12
Comment Actions
I changed the title as you suggest.
From my point of view, the whole point of bug 401290 was to get rid of the annoying dialogs popping up.
So I would argue that this does in fact fix the issue, even in a way that has an improvement in portability as a side effect.
BTW: bug fixes without any translation related changes could be applied to the stable branch, which is currently Applications/18.12
Sure, go ahead. The patch applies cleanly there too.
Comment Actions
Another view is that this patch bypasses the originally described error (the dialog box).
Comment Actions
With https://bugs.kde.org/show_bug.cgi?id=401290#c7 I can confirm, that this the related bug is really fixed by this patch.