Always show drawer on desktop
AbandonedPublic

Authored by nicolasfella on Nov 22 2018, 4:38 PM.

Details

Reviewers
vkrause
Summary

A side drawer is a strange concept on the desktop. Always having it open on the desktop (except for when the
widow is narrow) makes it feel more like a desktop application. The mobile build is unaffected by this.

Discover and KDE Connect do the same thing.

Test Plan

Wide window:

Narrow window:

Diff Detail

Repository
R1007 Itinerary - Travel Assistance Application
Branch
drawer
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5256
Build 5274: arc lint + arc unit
nicolasfella created this revision.Nov 22 2018, 4:38 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 22 2018, 4:38 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
nicolasfella requested review of this revision.Nov 22 2018, 4:38 PM
nicolasfella edited the test plan for this revision. (Show Details)Nov 22 2018, 4:40 PM
nicolasfella planned changes to this revision.Nov 22 2018, 4:49 PM

In this case it would make more sense to make the drawer a menu on the desktop

mart added a subscriber: mart.Nov 22 2018, 4:55 PM

looking at what's in the drawer, some actions that make it more suitable to have it in a toolbar or in a menu (while in sidebars usually there is stuff more alike to navigational items, like discover or kdeconnect)

I think in this case those entries should go into a menu, which i can try to think about a semi automated way to have it as a pattern

Thanks for looking into making this nicer on desktop!