SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox
ClosedPublic

Authored by loh.tar on Nov 22 2018, 3:18 PM.

Details

Summary

This patch alone is reasonable but become really important with the aim of D17030
and complies to D17056

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Nov 22 2018, 3:18 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptNov 22 2018, 3:18 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Nov 22 2018, 3:18 PM

It would be nice someone could explain, or point me where to read, why there is no (more) direct use of Sonnet stuff in KTextEditor/Kate.

  1. KTextEditor::SpellCheckBar looks (almost) the same as Sonnet::Dialog but has differently ingredients. I had expect, after my first poke around in Sonnet, that these are appear in Kate. Yes some, but not all.
  2. I was even more surprised to see that Sonnet ships some demo/test applications where the spellcheck, respectively correction by mouse, works like a charm with a morphed context menu shown only what is of interest, where as Kate shows the full menu where you have to fiddle down/around which is pretty annoying, almost unusable.

To 1., if it is desired to get rid of KTextEditor::SpellCheckBar and use Sonnet::Dialog, I would try to do it. The usability of both are not so nice. I use the Nano editor for some tasks and like there spell check user interface, very handy. Well, it's for me indeed a major reason to use Nano at all. So, I would try to "copy" that interface.

To 2., needless to emphasize, I like to see that in Kate too

cullmann accepted this revision.Nov 24 2018, 4:09 PM

I think neither the dialog/spellcheck bar nor the context menu things got any love in the close past.
If you have time to improve this, any patch is welcome!

I will apply this one and you can submit more things in a new patch.

This revision is now accepted and ready to land.Nov 24 2018, 4:09 PM
This revision was automatically updated to reflect the committed changes.