Make atcore Clazy tidy
ClosedPublic

Authored by rizzitello on Thu, Nov 22, 1:59 PM.

Diff Detail

Repository
R232 AtCore
Branch
clazy
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5285
Build 5303: arc lint + arc unit
rizzitello requested review of this revision.Thu, Nov 22, 1:59 PM
rizzitello created this revision.
rizzitello updated this revision to Diff 46009.Thu, Nov 22, 2:04 PM
rizzitello edited the summary of this revision. (Show Details)
  • fix spacing on comments in serialLayer
rizzitello updated this revision to Diff 46010.Thu, Nov 22, 2:11 PM
  • Const Ref text for WriteTempFile
  • Remove redundant void
  • Use auto
  • Use isEmpty() to replace test of empty object
patrickelectric requested changes to this revision.Thu, Nov 22, 2:23 PM

A great patch, thank you for cleaning this stuff.

src/core/atcore.cpp
61

why not 0.0 ?

70

Can we move the comments to be one space from the variable ? Or to separate it in blocks or in the previous line ? Everytime that something get bigger all lines need to change...

src/core/ifirmware.cpp
46

you can do that in header.

src/widgets/logwidget.cpp
41

(this) ?

This revision now requires changes to proceed.Thu, Nov 22, 2:23 PM
rizzitello updated this revision to Diff 46022.Thu, Nov 22, 4:12 PM
rizzitello marked 4 inline comments as done.
  • Use patrick's suggestions
src/core/atcore.cpp
89

Is there a why to use /** */ and not /* */ or ? ( makes it more simples).

rizzitello marked an inline comment as done.Thu, Nov 22, 6:36 PM
rizzitello added inline comments.
src/core/atcore.cpp
89

They are Doxygen comments.

rizzitello marked an inline comment as done.
  • Remove extra empty line
  • More Clazy stuff
rizzitello edited the summary of this revision. (Show Details)Fri, Nov 23, 12:57 AM
rizzitello updated this revision to Diff 46062.Fri, Nov 23, 5:38 AM
rizzitello edited the summary of this revision. (Show Details)
  • Remove new empty lines
patrickelectric requested changes to this revision.Fri, Nov 23, 9:51 AM
patrickelectric added inline comments.
src/widgets/about.cpp
37

(str, this)

56

this

This revision now requires changes to proceed.Fri, Nov 23, 9:51 AM
rizzitello updated this revision to Diff 46076.Fri, Nov 23, 2:41 PM
rizzitello marked an inline comment as done.
  • Missing parent
tcanabrava accepted this revision.Fri, Nov 23, 2:58 PM
patrickelectric accepted this revision.Sat, Nov 24, 3:50 PM
This revision is now accepted and ready to land.Sat, Nov 24, 3:50 PM
rizzitello closed this revision.Sat, Nov 24, 5:58 PM