Differential D17083

Fix hidden languages in the mode menu
ClosedPublic
Actions

Authored by nibags on Nov 21 2018, 7:46 PM.

Details

Reviewers
cullmann
Group Reviewers
KTextEditor
Commits
R39:bb5f34d7224d: Fix hidden languages in the mode menu
Summary

In the status bar, the syntax highlighting menu (mode menu) shows hidden languages, for example:

Others -> Alerts
Others -> Modelines

Diff Detail

Repository
R39 KTextEditor
Branch
fix-hidden-modes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5229
Build 5247: arc lint + arc unit
nibags created this revision.Nov 21 2018, 7:46 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptNov 21 2018, 7:46 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags requested review of this revision.Nov 21 2018, 7:46 PM
dhaumann added a subscriber: dhaumann.Nov 21 2018, 7:57 PM
dhaumann added inline comments.
src/mode/katemodemanager.cpp
102–103

Now the comment is wrong :) can you adapt it as well?

nibags updated this revision to Diff 45975.Nov 21 2018, 8:33 PM
  • Update comment
cullmann accepted this revision.Nov 24 2018, 4:17 PM
cullmann added a subscriber: cullmann.

Looks good, thanks!

This revision is now accepted and ready to land.Nov 24 2018, 4:17 PM
Closed by commit R39:bb5f34d7224d: Fix hidden languages in the mode menu (authored by nibags, committed by cullmann). · Explain WhyNov 24 2018, 4:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/mode/katemodemanager.cpp (5 lines)

Diff 45975

View Options

src/mode/katemodemanager.cpp

Loading...