Exposes their properties through Q_GADGET.
Makes it possible to export them as QVariant by declaring it and making it possible to create an empty instance of them.
Details
- Reviewers
dfaure aacid - Group Reviewers
Frameworks - Commits
- R244:2f8d7f43e1fe: Make it possible to use KAboutData/License/Person from QML
Tests still pass, see Discover patch.
Diff Detail
- Repository
- R244 KCoreAddons
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5392 Build 5410: arc lint + arc unit
You can change default values just fine, it requires re-compilation to use them but no ABI implications.
To be clear, it is possible to have a change in default values be BIC (as the page describes). The updated code has to still work in compatible fashion if called with old default values (if any), since that is what existing application binaries would have used.
There weren't default values before and even if there were, there's no change in behavior in the methods, so this change would be BC. From a source compat perspective, the changes made here do result in KAboutData becoming implicitly constructible when it wasn't before, which we may not want. Then again, maybe we do?
src/lib/kaboutdata.h | ||
---|---|---|
560–562 | Do we want to make this constructor explicit since the new default values now make it possible to construct a KAboutData with no parameters at all? |
adding a default value should be bc, the opposite of course is not..
in its current state, looks good to me
src/lib/kaboutdata.h | ||
---|---|---|
92 | Change "Default arguments @since 5.53" to "name default argument @since 5.53" |