Fix angle and margin of 32px dialog-ok-apply
ClosedPublic
Actions

Authored by trickyricky26 on Nov 20 2018, 8:25 PM.

Details

Reviewers

Group Reviewers

VDG
Breeze

Commits

R266:e1375f0efcdf: Fix angle and margin of 32px dialog-ok-apply

Summary

BUG: 393608

FIXED-IN: 5.53

Fix the off-angle of the checkmark and apply new 2px margins. Create symlinks from dialog-ok.svg and gtk-ok.svg to dialog-ok-apply.svg, as these are the for smaller sizes, but not 32px.

Test Plan

Before:

After:

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

trickyricky26 created this revision.Nov 20 2018, 8:25 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 20 2018, 8:25 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

trickyricky26 requested review of this revision.Nov 20 2018, 8:25 PM

Harbormaster completed remote builds in B5194: Diff 45914.Nov 20 2018, 8:25 PM

trickyricky26 edited the summary of this revision. (Show Details)Nov 20 2018, 8:28 PM

trickyricky26 edited the test plan for this revision. (Show Details)

trickyricky26 added reviewers: VDG, Breeze.

Looks good! D17033 needs to land before this or the two will conflict, but there's nothing you need to do.

This revision is now accepted and ready to land.Nov 20 2018, 9:04 PM

Actually, I do need you to do something, but the icons themselves are fine. I need you to rebase this patch onto master. I can walk you through it here or in a chat room if you need help.

This revision now requires changes to proceed.Nov 22 2018, 12:12 AM

Rebase onto master

Harbormaster completed remote builds in B5264: Diff 46036.Nov 22 2018, 8:00 PM

trickyricky26 retitled this revision from Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks to Fix angle and margin of 32px dialog-ok-apply.Nov 22 2018, 8:07 PM

All correct!

This revision is now accepted and ready to land.Nov 22 2018, 8:10 PM

Closed by commit R266:e1375f0efcdf: Fix angle and margin of 32px dialog-ok-apply (authored by trickyricky26, committed by ndavis). · Explain WhyNov 22 2018, 8:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		icons-dark/actions/32/dialog-ok-apply.svg (14 lines)
A	M	icons-dark/actions/32/dialog-ok.svg (1 line)
A	M	icons-dark/actions/32/gtk-ok.svg (1 line)
M		icons/actions/32/dialog-ok-apply.svg (14 lines)
A	M	icons/actions/32/dialog-ok.svg (1 line)
A	M	icons/actions/32/gtk-ok.svg (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45914	aace21a		Nov 20 2018, 8:25 PM	★	★
Diff 2	46036	2a85454	Rebase onto master	Nov 22 2018, 8:00 PM	★	★
Diff 3	46037	2a85454	R266:e1375f0efcdf6589344ce52cefe98b401caf4402	Nov 22 2018, 8:10 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
50978f0fe912	2d21714c0fc0	2a85454d7a42	Rafael Brandmaier	Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks (Show More…)	Nov 22 2018, 7:50 PM