Allow clicking of links in app descriptions
ClosedPublic

Authored by leinir on Nov 20 2018, 1:52 PM.

Details

Summary

Prior to this patch, links found in KNewStuff content descriptions were ignored and both unclickable and unselectable. With this patch, clicking a link will launch the default browser pointed at that link. Currently this is limited to KNS content, but it would be reasonably trivial to add to other content types as well, but thought it would be best to discuss on one type before doing them all at once.

This patch further fixes a minor oversight in the BBCode neutraliser in the KNS backend (which would previously eat chunks it was not supposed to, such as parts of URLs).

BUG: 401176

Diff Detail

Repository
R914 Discover KDE Website
Lint
Lint Skipped
Unit
Unit Tests Skipped
leinir created this revision.Nov 20 2018, 1:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 20 2018, 1:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Nov 20 2018, 1:52 PM
apol accepted this revision.Nov 20 2018, 2:15 PM

Looks good to me, maybe it would make sense to restrict it to http:?

This revision is now accepted and ready to land.Nov 20 2018, 2:15 PM
This revision was automatically updated to reflect the committed changes.