Differential D17046

Use the new FindExiv2 module from ECM.
ClosedPublic
Actions

Authored by krop on Nov 20 2018, 12:55 PM.

Details

Reviewers
mgallien
Commits
R286:c3cc05f4eee2: Use the new FindExiv2 module from ECM.
Summary

ECM 5.53 ships a modern FindExiv2.cmake module that will be needed
when exiv 0.27 is released.

Test Plan

Build succeeds, tests pass

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
krop created this revision.Nov 20 2018, 12:55 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 20 2018, 12:55 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
krop requested review of this revision.Nov 20 2018, 12:55 PM
mgallien accepted this revision.Nov 20 2018, 1:02 PM
mgallien added a subscriber: mgallien.

Please feel free to land this after solving my comment.

CMakeLists.txt
57

Maybe, you may not remove the URL. That would be consistent with other dependencies.

This revision is now accepted and ready to land.Nov 20 2018, 1:02 PM
krop marked an inline comment as done.Nov 20 2018, 1:04 PM
In D17046#362988, @mgallien wrote:

Please feel free to land this after solving my comment.

The new module already sets the description and URL

Closed by commit R286:c3cc05f4eee2: Use the new FindExiv2 module from ECM. (authored by krop). · Explain WhyNov 20 2018, 1:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)
Mautotests/CMakeLists.txt (6 lines)
DMcmake/FindExiv2.cmake (101 lines)
Msrc/extractors/CMakeLists.txt (5 lines)

Diff 45884

View Options

CMakeLists.txt

Loading...
View Options

autotests/CMakeLists.txt

Loading...
View Options

cmake/FindExiv2.cmake

Loading...
View Options

src/extractors/CMakeLists.txt

Loading...