fix dial pad UI by using density independent units
ClosedPublic

Authored by michaeleden on Nov 20 2018, 4:42 AM.

Details

Summary

I fixed the strange dialer on the phone, here's a picture:

Now I have a few questions:

  1. To get the '#', '*', & '+' symbols to show up I need to install a font that supports those glyphs. I've only found the font fonts-mplus. I can slice this font to only get those glyphs and package them here, or add this font as a dependency.

We should likely have a font like this installed anyway, so people can see weird glyphs on the internet.

  1. Is the correct way to set font sizes pixelSize: units.gridUnit?
Test Plan

manual testing?

Diff Detail

Repository
R20 Plasma Phone Components
Branch
fix/dialerpad-use-grid-units
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5165
Build 5183: arc lint + arc unit
michaeleden requested review of this revision.Nov 20 2018, 4:42 AM
michaeleden created this revision.
michaeleden edited the summary of this revision. (Show Details)Nov 20 2018, 4:52 AM
michaeleden edited the test plan for this revision. (Show Details)
michaeleden added reviewers: bshah, mart.

Changes looks good to me.

bshah accepted this revision.Nov 20 2018, 3:30 PM
This revision is now accepted and ready to land.Nov 20 2018, 3:30 PM
This revision was automatically updated to reflect the committed changes.