Add double tap to maximize screen brightness
ClosedPublic
Actions

Authored by nicolasfella on Nov 20 2018, 1:14 AM.

Details

Reviewers

Commits

R1007:442db7fa87c3: Add double tap to maximize screen brightness

Summary

For barcode scanning it's best to maximize the screen brightness. It's more useful on Android than on the desktop, but this implementation is useful for Plasma Mobile. I plan to add
support for Android later.

Test Plan

Double click on barcode, see screen getting brighter.

Diff Detail

Repository

R1007 Itinerary - Travel Assistance Application

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Nov 20 2018, 1:14 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 20 2018, 1:14 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

nicolasfella requested review of this revision.Nov 20 2018, 1:14 AM

Harbormaster completed remote builds in B5162: Diff 45860.Nov 20 2018, 1:14 AM

nicolasfella added a project: KDE Itinerary.Nov 20 2018, 1:30 AM

Nice! Definitely needed/wanted (see T8822). Does this somehow reset the brightness back to where it was before too, I don't seem to see that in the code? Anyway, this is a good start for this entire topic.

This revision is now accepted and ready to land.Nov 20 2018, 5:20 PM

There's no way to reset the brighness, right.

This patch introduces a optional runtime dep on Solid (or rather it's DBus interface), Should this be indicated in the CMakeLists.txt somehow?

In D17035#363267, @nicolasfella wrote:

There's no way to reset the brighness, right.

This patch introduces a optional runtime dep on Solid (or rather it's DBus interface), Should this be indicated in the CMakeLists.txt somehow?

That would probably be cleaner, yes, set_package_properties(... TYPE RUNTIME) should do that.

Look for Solid dependency

Harbormaster completed remote builds in B5313: Diff 46116.Nov 24 2018, 1:27 PM

Whitespace
Coding style

Harbormaster completed remote builds in B5314: Diff 46117.Nov 24 2018, 1:35 PM

nicolasfella requested review of this revision.Nov 24 2018, 1:35 PM

vkrause accepted this revision.Nov 24 2018, 1:44 PM

This revision is now accepted and ready to land.Nov 24 2018, 1:44 PM

Closed by commit R1007:442db7fa87c3: Add double tap to maximize screen brightness (authored by nicolasfella). · Explain WhyNov 24 2018, 2:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (4 lines)
M		src/app/CMakeLists.txt (6 lines)
M		src/app/PkPassBarcode.qml (5 lines)
M		src/app/TicketTokenDelegate.qml (5 lines)
A	M	src/app/brightnessmanager.h (49 lines)
A	M	src/app/brightnessmanager.cpp (41 lines)
M		src/app/main.cpp (3 lines)
A	M	src/app/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml (29 lines)
A	M	src/app/solidbrightnessbackend.h (39 lines)
A	M	src/app/solidbrightnessbackend.cpp (40 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45860	1697c9e		Nov 20 2018, 1:14 AM	★	★
Diff 2	46116	473be10	- Look for Solid dependency	Nov 24 2018, 1:27 PM	★	★
Diff 3	46117	473be10	- Whitespace	Nov 24 2018, 1:35 PM	★	★
Diff 4	46119	3271c40	R1007:442db7fa87c3b35e9732430849419866dd6d646b	Nov 24 2018, 2:19 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0cc0d92e4065	bb60fcd18cb1	98ecb5c6d3c2	Nicolas Fella	Coding style	Nov 24 2018, 1:34 PM
98ecb5c6d3c2	23570b663482	bc925e387a53	Nicolas Fella	Whitespace	Nov 24 2018, 1:31 PM
bc925e387a53	776bb60d6a86	50bde5e912dd	Nicolas Fella	Look for Solid dependency	Nov 24 2018, 1:25 PM
50bde5e912dd	63974fd1c762	473be106242a	Nicolas Fella	Add double tap to maximize screen brightness (Show More…)	Nov 20 2018, 1:12 AM