Change primary monochrome icon colors to match new HIG colors
ClosedPublic

Authored by ndavis on Nov 19 2018, 10:38 PM.

Details

Summary

The old colors were Icon Grey (#4d4d4d, breeze) and an undocumented white color (#f2f2f2, breeze-dark). The new colors are Shade Black (#232629, breeze) and Cardboard Grey (#eff0f1, breeze-dark).

With this change, icons in GTK applications will be the same color as icons in Qt applications with the Breeze and Breeze Dark colorschemes.

I used sed --follow-symlinks -i 's/4d4d4d/232629/' *.svg for breeze and sed --follow-symlinks -i 's/f2f2f2/eff0f1/' *.svg for breeze-dark in each directory containing monochrome icons, excluding the color icons in apps/16 and apps/22

Test Plan

I'm unsure how to prove that everything is as it should be with such a massive amount of small changes, but I did look through the diff for every file in git-dag and found no mistakes.

Diff Detail

Repository
R266 Breeze Icons
Branch
fix-primary-monochrome-colors (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5160
Build 5178: arc lint + arc unit
ndavis created this revision.Nov 19 2018, 10:38 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 19 2018, 10:38 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Nov 19 2018, 10:38 PM
ndavis edited the summary of this revision. (Show Details)Nov 19 2018, 10:41 PM

Thanks for the update, I will work with the new colors also in LibO. We have there an issue on OS-X cause the contrast was not good enough and the new darker color will give an better contrast.

ndavis edited the summary of this revision. (Show Details)Nov 19 2018, 10:57 PM
ngraham accepted this revision.Nov 21 2018, 5:14 AM
ngraham added a subscriber: ngraham.

From visual inspection of /usr/share/icons/breeze/actions/* in Dolphin after deploying the change, it's quite visible--and quite a noticeable improvement, which I imagine will be much appreciated by non-Plasma users. It's a lot to scroll through, but it all looks good to me! Nicely done.

This revision is now accepted and ready to land.Nov 21 2018, 5:14 AM
This revision was automatically updated to reflect the committed changes.