Adds a menu item to toggle comments and adds CTRL + / as a shortcut. Also removes "Comment"/"Uncomment" menu items (but keeps the shortcuts to avoid breaking muscle memory).
BUG: 387654
ngraham | |
cullmann |
VDG | |
Kate | |
KTextEditor |
Adds a menu item to toggle comments and adds CTRL + / as a shortcut. Also removes "Comment"/"Uncomment" menu items (but keeps the shortcuts to avoid breaking muscle memory).
BUG: 387654
Test both old and new shortcuts and the new menu item.
No Linters Available |
No Unit Test Coverage |
Buildable 5155 | |
Build 5173: arc lint + arc unit |
Lovely, this is just what I wanted. It's cool that the feature was already there. :) I like how you preserve the old shortcuts for compatibility. Just a few changes needed from my perspective:
src/data/katepart5ui.rc | ||
---|---|---|
2 | You need to bump the version to 79 or else the changes won't take effect. | |
src/view/kateview.cpp | ||
543–544 | Could we also change this string to say "Comment/Uncomment" Rather than "Toggle comment"? I know that's technically correct because this is a toggle action, but generally one doesn't associate "toggling" things with text editing. |
src/data/katepart5ui.rc | ||
---|---|---|
2 | That might explain why the changes only sometimes appeared. Fixed :) | |
src/view/kateview.cpp | ||
543–544 | I think they both make sense, but "Toggle Comment" seems to be the established standard. Three out of my four installed editors used that wording (the last one only used "Comment"). |