Do hash and hex name based output hashes
ClosedPublic

Authored by romangg on Nov 19 2018, 9:55 AM.

Details

Summary

The hash of an output is based on its name in case no EDID information is
available. In order to have the same hash format as when EDID is available
do the same hash operation to the name as to the EDID checksum.

Introduce the new hashMd5 function and deprecate the previous hash
function. This way we can use the new function, which does hash the
output names correctly, in cases where it makes sense and no user configs
break.

Test Plan

Compiles.

Diff Detail

Repository
R110 KScreen Library
Branch
hashOutputNameHash
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12702
Build 12720: arc lint + arc unit
romangg created this revision.Nov 19 2018, 9:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 19 2018, 9:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Nov 19 2018, 9:55 AM
mart added a subscriber: mart.Nov 23 2018, 11:42 AM

could a kconfigupdate script be provided to migrate config?
screwing up multiscreen config between updated is quite of an issue

lbeltrame requested changes to this revision.Nov 23 2018, 12:52 PM
lbeltrame added a subscriber: lbeltrame.

As a packager: messing up with user configuration without a clear migration path is a no-no.

This revision now requires changes to proceed.Nov 23 2018, 12:52 PM
In D17007#364724, @mart wrote:

could a kconfigupdate script be provided to migrate config?
screwing up multiscreen config between updated is quite of an issue

Difficult, maybe mathematically not even possible since we would invert the hash operation in some of the configuration files.

If we want to keep the configuration files in valid state we could leave it as is for now (even though it's ugly) and do this hash transform in KDE6.

romangg updated this revision to Diff 57751.May 8 2019, 9:10 AM

Deprecate hash function instead of altering its behavior. This way we can
use the new function, which does hash the output names correctly, in cases
where it makes sense and no user configs break.

romangg updated this revision to Diff 59625.Jun 11 2019, 9:31 PM

Rebase on master.

romangg edited the summary of this revision. (Show Details)Jun 12 2019, 2:07 PM
romangg edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Jun 13 2019, 9:50 AM
This revision was automatically updated to reflect the committed changes.