Differential D16996

Add method to write retention to configuration control files
ClosedPublic
Actions

Authored by romangg on Nov 18 2018, 11:35 PM.

Tags

Subscribers

mart, plasma-devel

Details

Reviewers

Group Reviewers

Maniphest Tasks

T10028: Individual KScreen output data retention

Commits

R104:06b90b31068e: Add method to write retention to configuration control files

Summary

This patch adds a small method to ControlConfig which writes modified
retention values to the control file of the configuration.

Test Plan

Compiles.

Diff Detail

Repository

Branch

1controlWrite

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11640
Build 11658: arc lint + arc unit

romangg created this revision.Nov 18 2018, 11:35 PM

Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2018, 11:35 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

romangg requested review of this revision.Nov 18 2018, 11:35 PM

Harbormaster completed remote builds in B5113: Diff 45767.Nov 18 2018, 11:35 PM

romangg added a dependency: D16995: Consider identical display models in ControlConfig.Nov 18 2018, 11:35 PM

romangg added a dependent revision: D16997: [kcm] Expose interface to control output property retention.Nov 18 2018, 11:46 PM

mart accepted this revision.Nov 23 2018, 11:49 AM

mart added a subscriber: mart.

mart added inline comments.

common/control.cpp
178	maybe check if it's actually a valid json document?, even just !document.isEmpty() after creating the document

This revision is now accepted and ready to land.Nov 23 2018, 11:49 AM

ngraham added a task: T10028: Individual KScreen output data retention.May 2 2019, 5:35 PM

Rebase on series changes.

Harbormaster completed remote builds in B11603: Diff 57670.May 6 2019, 5:17 PM

Rebase on series changes.

Harbormaster completed remote builds in B11640: Diff 57719.May 7 2019, 1:59 PM

Rebase on series changes.

Harbormaster completed remote builds in B11710: Diff 57834.May 9 2019, 11:49 PM

Rebase on master.

Harbormaster completed remote builds in B12736: Diff 59669.Jun 12 2019, 4:59 PM

Rebase on series changes.

Harbormaster completed remote builds in B12769: Diff 59719.Jun 13 2019, 11:43 AM

Fix newline

Harbormaster completed remote builds in B12771: Diff 59721.Jun 13 2019, 11:45 AM

Closed by commit R104:06b90b31068e: Add method to write retention to configuration control files (authored by romangg). · Explain WhyJun 13 2019, 9:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			common/control.h (5 lines)
M			common/control.cpp (84 lines)

Diff 57719

common/control.h

Loading...

common/control.cpp

Loading...