Port application menu to qqc2
AbandonedPublic

Authored by astippich on Nov 17 2018, 9:21 AM.

Details

Reviewers
mgallien
Summary

Ports the popup when clicking the hamburger button
to qqc2. Currently, the assigned shortcuts are not visible.
T7576

Diff Detail

Repository
R255 Elisa
Branch
qqc2_menu
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5016
Build 5034: arc lint + arc unit
astippich requested review of this revision.Nov 17 2018, 9:21 AM
astippich created this revision.
astippich edited the summary of this revision. (Show Details)Nov 18 2018, 11:38 AM
astippich added a project: Elisa.
mgallien requested changes to this revision.Nov 19 2018, 8:26 PM

The menu is no longer a sub window manage by the windowing system. Is this really a good idea ?

The look and the lack of shortcut display are blocker points as this is clearly a regression.

After the tests I had done, I am convinced that we should first fix the stack used by Elisa before pushing this kind of changes.

This revision now requires changes to proceed.Nov 19 2018, 8:26 PM

After the tests I had done, I am convinced that we should first fix the stack used by Elisa before pushing this kind of changes.

I agree. FWIW, the visual problem is tracked by https://bugs.kde.org/show_bug.cgi?id=400905

Sorry, forgot to write a comment. This is not meant to be merged right now, I wanted to start a discussing which type of menu Elisa should use, e.g. the item-based (standard qqc2) or the native one (Qt.labs).
Both currently have issues which need to be fixed first.
I have at least an idea what could be done to fix the item-based solution, and I have no clue what's going wrong with the native solution.

astippich abandoned this revision.Jan 5 2019, 9:41 PM