QString::mid() will create a new string, but this code path will never use the
old variable again. So simply modify the original copy instead.
CMakeCacheModel: remove impossible case
Exactly the same case has been checked 2 if's before.
QString::mid() will create a new string, but this code path will never use the
old variable again. So simply modify the original copy instead.
CMakeCacheModel: remove impossible case
Exactly the same case has been checked 2 if's before.
No Linters Available |
No Unit Test Coverage |
Buildable 5014 | |
Build 5032: arc lint + arc unit |
plugins/cmake/settings/cmakecachemodel.cpp | ||
---|---|---|
76 | would be easier to just write currentComment += line.midRef(2); |
plugins/cmake/settings/cmakecachemodel.cpp | ||
---|---|---|
76 | Since "line" itself goes away after this loop there isn't anything to ref anymore, and I honestly don't know if this will work then. currentComment is a QStringList, no QString. |