Unset all env variables related to KDE session in integration tests
ClosedPublic

Authored by graesslin on Nov 17 2018, 8:52 AM.

Details

Summary

When running ctest in my session a few OpenGL/waylandonly tests crashed
on tear down. This does neither happen on build.kde.org nor when running
ctest in a tty. Comparing the env variables of tty and session pointed
to the session variables. Unsetting those makes the test not crash. This
makes sense as e.g. plasma-integration no longer gets loaded.

As our test suite is intended to test KWin and not plasma-integration or
gnome integration we should have a clean and reproducable environment,
so the variables are unset.

Test Plan

100% tests passed, 0 tests failed out of 130

Diff Detail

Repository
R108 KWin
Branch
no-session-in-tests
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5011
Build 5029: arc lint + arc unit
graesslin created this revision.Nov 17 2018, 8:52 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 17 2018, 8:52 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Nov 17 2018, 8:52 AM
davidedmundson accepted this revision.Nov 17 2018, 12:00 PM
This revision is now accepted and ready to land.Nov 17 2018, 12:00 PM
This revision was automatically updated to reflect the committed changes.