Delete kglobalshortcutsrc before executing a test
ClosedPublic

Authored by graesslin on Nov 16 2018, 7:48 PM.

Details

Summary

When running the complete test suite the ScriptedEffectsTest::testShortcuts
registers the shortcut meta+shift+y. But GlobalShortcutsTest::testX11ClientShortcut
also tries to use this shortcut for a window shortcut which fails if it
is already registered. So when running the complete test suite it
depends on the order of execution whether the GlobalShortcutsTest passes
or not.

Test should be clean - also the globalshortcuts. As the config is read
from test directory anyway, we can delete the file prior to init of
kglobalaccel.

Test Plan

Run ctest, test did not fail anymore

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Nov 16 2018, 7:48 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 16 2018, 7:48 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Nov 16 2018, 7:48 PM
davidedmundson accepted this revision.Nov 19 2018, 8:48 AM
This revision is now accepted and ready to land.Nov 19 2018, 8:48 AM
This revision was automatically updated to reflect the committed changes.