Differential D16929

Remove dead search provider
ClosedPublic
Actions

Authored by vkrause on Nov 16 2018, 6:18 PM.

Details

Reviewers
krop
Group Reviewers
Frameworks
Commits
R241:abfddc54afc0: Remove dead search providers
Summary

These services have dead or parking domains, or consistently produce timeouts.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Nov 16 2018, 6:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 16 2018, 6:18 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Nov 16 2018, 6:18 PM
vkrause updated this revision to Diff 45609.Nov 16 2018, 7:27 PM

Remove more dead search providers, just checking for non-resolving domains isn't enough.

vkrause retitled this revision from Remove dmoz search provider to Remove dead search provider.Nov 16 2018, 7:28 PM
vkrause edited the summary of this revision. (Show Details)
krop added a subscriber: krop.Nov 16 2018, 10:23 PM
In D16929#360570, @vkrause wrote:

Remove more dead search providers, just checking for non-resolving domains isn't enough.

mmh.. http://www.cnrtl.fr/definition/$something works fine here

vkrause added a comment.Nov 17 2018, 9:29 AM
In D16929#360646, @cgiboudeaux wrote:
In D16929#360570, @vkrause wrote:

Remove more dead search providers, just checking for non-resolving domains isn't enough.

mmh.. http://www.cnrtl.fr/definition/$something works fine here

Indeed, thanks for checking!
My browser history suggests I had a typo in the URL when manually verifying the results of my test script, which reported issues with that site due to it not supporting TLS.

vkrause updated this revision to Diff 45632.Nov 17 2018, 9:31 AM

Restore dictfr.desktop, that actually still works, just not with HTTPS.

krop accepted this revision.Nov 24 2018, 11:42 AM
This revision is now accepted and ready to land.Nov 24 2018, 11:42 AM
Closed by commit R241:abfddc54afc0: Remove dead search providers (authored by vkrause). · Explain WhyNov 24 2018, 12:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46112

View Options

src/urifilters/ikws/searchproviders/dmoz.desktop

Loading...
View Options

src/urifilters/ikws/searchproviders/ibl.desktop

Loading...