[wayland] Fix ShellClientTest
ClosedPublic

Authored by davidedmundson on Nov 16 2018, 11:10 AM.

Details

Summary

When switching from maximised to full screen the geometry as kwin sees
it doesn't necessarily need to change, the test is wrong.

Also we can fix the XDGShell-deco tests.

wlshell-deco test still fails as before.

Test Plan

Tests pass \o/

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: KWin. · View Herald TranscriptNov 16 2018, 11:10 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Nov 16 2018, 11:10 AM
graesslin accepted this revision.Nov 16 2018, 11:58 AM
This revision is now accepted and ready to land.Nov 16 2018, 11:58 AM
This revision was automatically updated to reflect the committed changes.

The test seems to be flaky. Sometimes it fails with:

FAIL!  : TestShellClient::testMaximizedToFullscreen(xdgShellV6 - deco) Compared values are not the same
   Actual   (sizeChangeRequestedSpy.last().first().toSize()): QSize(1280x987)
   Expected (QSize(100, 50))                                : QSize(100x50)
   Loc: [/home/martin/src/kde/workspace/kwin/autotests/integration/shell_client_test.cpp(739)]