Always provide an icon for toolbar and maybe a label

Authored by alex-l on Nov 15 2018, 6:55 PM.



Currently the Kirigami implementation needs icons defined for the three actions displayed in the header bar in desktop mode because in mobile mode they are turned into Floating Action Buttons with no labels. So the app developer should provide a label for those actions as good practice but should also keep in mind that the icon is needed and that the label could be hidden (in mobile mode and also when there isn't enough space when the window is resized).

Diff Detail

R985 KDE Human Interface Guidelines
Lint Skipped
Unit Tests Skipped
alex-l requested review of this revision.Nov 15 2018, 6:55 PM
alex-l created this revision.
mart added a comment.Nov 16 2018, 4:03 PM
This comment was removed by mart.
mart accepted this revision.Nov 16 2018, 4:07 PM


This revision is now accepted and ready to land.Nov 16 2018, 4:07 PM
ngraham accepted this revision.Nov 16 2018, 4:09 PM

Makes sense to me.

fabianr accepted this revision.Nov 25 2018, 4:22 PM
ngraham closed this revision.Dec 5 2019, 9:58 PM

Looks like this guideline has since been added to the HIG. Sorry this patch sat here for ages like this!