Differential D16902

Arrange docker: UI polish
ClosedPublic
Actions

Authored by amedonosova on Nov 15 2018, 4:39 PM.

Details

Reviewers

rempt

Group Reviewers

Krita

Commits

R37:cdc608d37ade: Arrange docker: UI polish
R37:2883c08abef9: Arrange docker: UI polish

Summary

New, more legible layout.
The arrange controls work only with the Select Shapes Tool. If another tool is active, the docker displays a message instead of the buttons. (Fixes bug 394084.)
Also fixes mismatched align icons (bug 399984).

BUG: 399984
BUG: 394084

Diff Detail

Repository

R37 Krita

Branch

amedonosova/arrange-docker

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4965
Build 4983: arc lint + arc unit

amedonosova created this revision.Nov 15 2018, 4:39 PM

Restricted Application added a reviewer: Krita. · View Herald TranscriptNov 15 2018, 4:39 PM

Restricted Application added a project: Krita. · View Herald Transcript

amedonosova requested review of this revision.Nov 15 2018, 4:39 PM

Harbormaster completed remote builds in B4965: Diff 45529.Nov 15 2018, 4:39 PM

That looks fine. The only thing I wonder about is whether there isn't a way to bunch all the buttons up at the top of the docker when making it tall -- now there's some spacing appearing between the rows if you stretch the docker. But that's not new.

This revision is now accepted and ready to land.Nov 16 2018, 8:34 AM

In D16902#360199, @rempt wrote:

That looks fine. The only thing I wonder about is whether there isn't a way to bunch all the buttons up at the top of the docker when making it tall -- now there's some spacing appearing between the rows if you stretch the docker. But that's not new.

Thanks.

I'm not sure I understand the issue correctly. In my build, there is no change in spacing if I resize the docker. I will merge it to master and investigate in the CI nightly builds.

Closed by commit R37:cdc608d37ade: Arrange docker: UI polish (authored by amedonosova). · Explain WhyNov 16 2018, 2:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			krita/pics/misc-dark/dark_ox16-action-object-align-horizontal-left-calligra.svg (49 lines)
M			krita/pics/misc-dark/dark_ox16-action-object-align-horizontal-right-calligra.svg (49 lines)
M			krita/pics/misc-dark/misc-dark-icons.qrc (4 lines)
M			krita/pics/misc-light/light_ox16-action-object-align-horizontal-left-calligra.svg (48 lines)
M			krita/pics/misc-light/light_ox16-action-object-align-horizontal-right-calligra.svg (48 lines)
M			krita/pics/misc-light/misc-light-icons.qrc (4 lines)
M			plugins/dockers/arrangedocker/arrange_docker_widget.h (1 line)
M			plugins/dockers/arrangedocker/arrange_docker_widget.cpp (11 lines)
M			plugins/dockers/arrangedocker/arrange_docker_widget.ui (774 lines)
M			plugins/dockers/arrangedocker/arrangedocker_dock.h (1 line)
M			plugins/dockers/arrangedocker/arrangedocker_dock.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45529	98de1e6		Nov 15 2018, 4:39 PM	★	★
Diff 2	45590	ef07748	R37:cdc608d37ade87ed6ce45119d9352af9c8bab4ce	Nov 16 2018, 2:33 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
33a9a7b751a6	6f86234520f1	d470a6d117f8	Anna Medonosova	arrange docker: non-compatible tool warning	Nov 15 2018, 4:30 PM
d470a6d117f8	9a69a1dd41cb	800e3ac456fa	Anna Medonosova	arrange docker: new layout	Nov 15 2018, 4:30 PM
800e3ac456fa	4b6028af9430	98de1e6769a2	Anna Medonosova	Arrange docker: UI polish (Show More…)	Nov 12 2018, 5:01 PM