Differential D16891

[logout-greeter] Use correct enum for logout hint to QML
ClosedPublic
Actions

Authored by davidedmundson on Nov 15 2018, 8:18 AM.

Details

Reviewers
mart
Commits
R120:02541b8af06e: [logout-greeter] Use correct enum for logout hint to QML
Summary

Libkworkspace has two duplicate enum values for the same thing, with one
marked as "//FIXME remove". My patchset is trying to kill that enum, but
we still use it for backwards compatibility in the L&F QML in the greeter.

In my split, I used the wrong one.

BUG: 401046

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 15 2018, 8:18 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 15 2018, 8:18 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 15 2018, 8:18 AM
davidedmundson retitled this revision from [logout-greeter] Use correct enum for logout hint to QMQL. to [logout-greeter] Use correct enum for logout hint to QML.Nov 15 2018, 10:28 AM
davidedmundson edited the summary of this revision. (Show Details)
mart accepted this revision.Nov 15 2018, 11:27 AM
This revision is now accepted and ready to land.Nov 15 2018, 11:27 AM
Closed by commit R120:02541b8af06e: [logout-greeter] Use correct enum for logout hint to QML (authored by davidedmundson). · Explain WhyNov 15 2018, 11:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlogout-greeter/greeter.cpp (2 lines)

Diff 45508

View Options

logout-greeter/greeter.cpp

Loading...