It still has one problem, after configuration is changed in Entries MouseArea index is invalid, i can't understand why, @broulik ?
BUG: 390890
broulik | |
davidedmundson | |
ngraham |
Plasma |
It still has one problem, after configuration is changed in Entries MouseArea index is invalid, i can't understand why, @broulik ?
BUG: 390890
again 2
again 4
All good, but after close configuration dialog clicking on item in systray is an invalid index.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Weird. If configuration window stays open, clicks in systray work correct, when it's dismissed clicks are incorrect.
I think that's a Qt bug, i did an investigation in another systray bug report but can't find it right now
I don't understand.
The only usage of plasmoidItemComponent is in " Containment.onAppletAdded:", so how is this going to make any difference?
But for some reason, on second Entries show warnings says: cannot call createObject on null object. Looks like it is treated as local object or something.
I think that is not the root cause. You should fix the root cause instead of just a part of it.
See my comment on https://bugs.kde.org/show_bug.cgi?id=393630#c25
If it's a Qt bug, our options are to fix it upstream, or work around it here with a comment in the code indicating the workaround and the Qt bug report. Can you add that?
The bug has been reported before!
https://bugreports.qt.io/browse/QTBUG-71238 / https://bugreports.qt.io/browse/QTBUG-72004
Ignore the title and context, read the comment from Kai about the component without a parent getting cleaned up.
That moves this from working round an "unknown", to working round a "known" issue.
Seems a tiny difference, but means a lot to whether I accept it.
@anthonyfieroni can you add a comment in the code that indicates the Qt issues this is working around?
We've got three days until 5.15 tagging. Let's try to get this in!