Differential D16887

Send all active downloads on load
ClosedPublic
Actions

Authored by broulik on Nov 15 2018, 2:05 AM.

Details

Reviewers
davidedmundson
fvogt
Group Reviewers
Plasma
Commits
R856:7bb04c749f67: Send all active downloads on load
Summary

Ensures when the extension is reloaded any downloads currently running are still shown in notifications

Test Plan

I remember getting some bogus downloads.onCreated events on browser startup but when reloading the extension doesn't seem to do this

  • started a download, reloaded the extension, download was removed from notifications applet because the host binary quit and then re-created once the extension was up and running again, instead of just vanishing forever

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 15 2018, 2:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 15 2018, 2:05 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 15 2018, 2:05 AM
broulik edited the test plan for this revision. (Show Details)Nov 15 2018, 2:17 AM
davidedmundson accepted this revision.Nov 15 2018, 9:06 AM
This revision is now accepted and ready to land.Nov 15 2018, 9:06 AM
Closed by commit R856:7bb04c749f67: Send all active downloads on load (authored by broulik). · Explain WhyNov 15 2018, 6:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/extension.js (16 lines)

Diff 45536

View Options

extension/extension.js

Loading...