Differential D16874

[kded] Replace configReady functon with lambda
ClosedPublic
Actions

Authored by romangg on Nov 14 2018, 9:14 AM.

Tags

Subscribers

davidedmundson, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R104:980b100770bb: [kded] Replace configReady functon with lambda

Summary

Purely for cosmetic reasons.

Test Plan

Compiles.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Nov 14 2018, 9:14 AM

Restricted Application added a project: Plasma. · View Herald TranscriptNov 14 2018, 9:14 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

romangg requested review of this revision.Nov 14 2018, 9:14 AM

Harbormaster completed remote builds in B4926: Diff 45446.Nov 14 2018, 9:14 AM

Note, that the configReady function was a public slot in an exported class, so is it safe? I would like to change other stuff in this class definition. I don't know why the class is exported and who consumes it.

romangg retitled this revision from [daemon] Replace configReady functon with lambda to [kded] Replace configReady functon with lambda.Nov 14 2018, 9:16 AM

romangg added a dependent revision: D16875: [kded] Cleanup KScreenDaemon class.Nov 14 2018, 10:15 AM

Note, that the configReady function was a public slot in an exported class, so is it safe?

it's not in a library that people link to, so you can do whatever.

davidedmundson accepted this revision.Nov 14 2018, 11:56 AM

This revision is now accepted and ready to land.Nov 14 2018, 11:56 AM

Closed by commit R104:980b100770bb: [kded] Replace configReady functon with lambda (authored by romangg). · Explain WhyNov 14 2018, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kded/daemon.h (1 line)
M			kded/daemon.cpp (21 lines)

Diff 45467

kded/daemon.h

Loading...

kded/daemon.cpp

Loading...