Differential D16874

[kded] Replace configReady functon with lambda
ClosedPublic
Actions

Authored by romangg on Nov 14 2018, 9:14 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R104:980b100770bb: [kded] Replace configReady functon with lambda
Summary

Purely for cosmetic reasons.

Test Plan

Compiles.

Diff Detail

Repository
R104 KScreen
Branch
codeCleanupDaemonStartup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4926
Build 4944: arc lint + arc unit
romangg created this revision.Nov 14 2018, 9:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 14 2018, 9:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Nov 14 2018, 9:14 AM
romangg added a comment.Nov 14 2018, 9:16 AM

Note, that the configReady function was a public slot in an exported class, so is it safe? I would like to change other stuff in this class definition. I don't know why the class is exported and who consumes it.

romangg retitled this revision from [daemon] Replace configReady functon with lambda to [kded] Replace configReady functon with lambda.Nov 14 2018, 9:16 AM
davidedmundson added a subscriber: davidedmundson.Nov 14 2018, 11:29 AM

Note, that the configReady function was a public slot in an exported class, so is it safe?

it's not in a library that people link to, so you can do whatever.

davidedmundson accepted this revision.Nov 14 2018, 11:56 AM
This revision is now accepted and ready to land.Nov 14 2018, 11:56 AM
Closed by commit R104:980b100770bb: [kded] Replace configReady functon with lambda (authored by romangg). · Explain WhyNov 14 2018, 6:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/daemon.h (1 line)
Mkded/daemon.cpp (21 lines)

Diff 45446

View Options

kded/daemon.h

Loading...
View Options

kded/daemon.cpp

Loading...