Removed old-style casting warnings
ClosedPublic

Authored by msuarez on Nov 13 2018, 12:30 PM.

Details

Summary

To remove the 'old-style casting' warnings, replaced the old (type) cast to static_cast, dynamic_cast or reinterpret_cast

Diff Detail

Repository
R337 KTurtle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
msuarez created this revision.Nov 13 2018, 12:30 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 13 2018, 12:30 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
msuarez requested review of this revision.Nov 13 2018, 12:30 PM
yurchor added inline comments.
src/sprite.cpp
59–60

This might be a stupid question but isn't it enough to write just

sqrt(2.0)

or

sqrt(2.0L)

?
Thanks in advance for your answers.

rizzitello accepted this revision.Nov 13 2018, 12:48 PM

This will have some conflict with D16463. Remember to update this if that lands first.

This revision is now accepted and ready to land.Nov 13 2018, 12:48 PM
apol added a subscriber: apol.Nov 13 2018, 1:58 PM

Note you have changed the indentation of the modified lines. Make sure indentation isn't changed (unless it's required specificly).

In D16863#358962, @apol wrote:

Note you have changed the indentation of the modified lines. Make sure indentation isn't changed (unless it's required specificly).

a .editorconfig file with the correct configuration for the project will save some time for this in the future. I'll send a .editorconfig file for the projects that my students are working on.

tcanabrava requested changes to this revision.Nov 15 2018, 2:50 PM

Waiting for the whitespace clenaup before merging.

This revision now requires changes to proceed.Nov 15 2018, 2:50 PM
msuarez updated this revision to Diff 45522.Nov 15 2018, 3:14 PM
  • fixed the indentation changes of the modified lines
tcanabrava accepted this revision.Nov 15 2018, 3:53 PM
tcanabrava added inline comments.
src/canvas.cpp
114–115

This was using space and she changed to tabs, I'll allow this pass.

This revision is now accepted and ready to land.Nov 15 2018, 3:53 PM
msuarez updated this revision to Diff 45526.Nov 15 2018, 4:00 PM
  • fixed the indentation changes of the modified lines
  • fixed author name
This revision was automatically updated to reflect the committed changes.