[effects] Move Fade, Glide, and Scale effect into exclusive group
ClosedPublic
Actions

Authored by zzag on Nov 13 2018, 10:18 AM.

Details

Reviewers

ngraham
graesslin

Group Reviewers

Commits

Summary

Fade, glide, and scale effect are mutually exclusive effects so they have
to be put into an exclusive group in the desktop effects kcm.

Test Plan

Repository

R108 KWin

Branch

split-fade-effect

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 4894
Build 4912: arc lint + arc unit

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Nov 13 2018, 10:18 AM

zzag edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Nov 13 2018, 11:01 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			effects/effect_builtins.cpp (4 lines)
M			effects/fade/package/metadata.desktop (3 lines)
M			effects/scale/package/metadata.desktop (3 lines)
M			kcmkwin/kwincompositing/model.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45401	abd3d20		Nov 13 2018, 10:18 AM	★	★
Diff 2	45532	c98e6cb	R108:fb68e162b0c3d5c88ddf83477ade541957c0580f	Nov 15 2018, 5:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4ff8b5c8d99a	9ce2472356ae	abd3d206eddc	Vlad Zagorodniy	[effects] Move Fade, Glide, and Scale effect into exclusive group (Show More…)	Nov 12 2018, 7:25 PM

Status	Author	Revision
Closed	zzag	D16858 [effects] Move Fade, Glide, and Scale effect into exclusive group
Closed	zzag	D16836 [effects] Split the Fade effect
Closed	zzag	D16835 Don't cache value of popupWindow property in EffectWindow